test: Improve trigger non fully blocking AppHang#4265
Merged
philipphofmann merged 2 commits intomainfrom Aug 9, 2024
Merged
Conversation
Make triggering a non-fully blocking app hang where some frames are rendered, but the UI still seems stuck to the user more realistic by continuously blocking the main thread for 0.5 seconds and then quickly rendering a few frames and then blocking it again.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4265 +/- ##
=============================================
+ Coverage 91.510% 91.530% +0.020%
=============================================
Files 612 612
Lines 49470 49471 +1
Branches 17902 17920 +18
=============================================
+ Hits 45270 45281 +11
+ Misses 4107 4098 -9
+ Partials 93 92 -1 see 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e998fd0 | 1241.49 ms | 1262.63 ms | 21.14 ms |
| b15521e | 1221.69 ms | 1237.51 ms | 15.82 ms |
| ef5821b | 1253.18 ms | 1265.46 ms | 12.28 ms |
| 533c68f | 1236.54 ms | 1256.68 ms | 20.14 ms |
| 4ae9b7a | 1223.94 ms | 1243.90 ms | 19.96 ms |
| 5230990 | 1222.86 ms | 1243.59 ms | 20.73 ms |
| bd2afa6 | 1241.37 ms | 1246.20 ms | 4.83 ms |
| 189b629 | 1211.16 ms | 1224.30 ms | 13.14 ms |
| 3f1be0f | 1208.12 ms | 1225.72 ms | 17.60 ms |
| 3de9971 | 1224.38 ms | 1245.33 ms | 20.95 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e998fd0 | 21.58 KiB | 414.59 KiB | 393.01 KiB |
| b15521e | 21.58 KiB | 573.17 KiB | 551.59 KiB |
| ef5821b | 21.58 KiB | 414.96 KiB | 393.37 KiB |
| 533c68f | 21.58 KiB | 630.28 KiB | 608.70 KiB |
| 4ae9b7a | 21.58 KiB | 632.04 KiB | 610.46 KiB |
| 5230990 | 21.58 KiB | 682.39 KiB | 660.81 KiB |
| bd2afa6 | 20.76 KiB | 420.55 KiB | 399.79 KiB |
| 189b629 | 20.76 KiB | 399.69 KiB | 378.93 KiB |
| 3f1be0f | 20.76 KiB | 414.44 KiB | 393.69 KiB |
| 3de9971 | 21.58 KiB | 574.17 KiB | 552.59 KiB |
armcknight
approved these changes
Aug 8, 2024
Samples/iOS-Swift/iOS-Swift.xcodeproj/xcshareddata/xcschemes/iOS-Swift.xcscheme
Outdated
Show resolved
Hide resolved
…OS-Swift.xcscheme Co-authored-by: Andrew McKnight <andrew.mcknight@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make triggering a non-fully blocking app hang where some frames are rendered, but the UI still seems stuck to the user more realistic by continuously blocking the main thread for 0.5 seconds and then quickly rendering a few frames and then blocking it again.
#skip-changelog